Seekra/frontend
3
2
Fork 0
generated from Seekra/repository-template
Code Issues 4 Pull Requests Actions Packages Projects 1 Releases Wiki Activity

use logo #52

Merged
jakob.scheid merged 8 commits from feature/use-logo into main 2026-05-15 18:53:04 +02:00
Conversation 4 Commits 8 Files Changed 3
+20 -22
johannes.vos commented 2026-05-15 17:26:47 +02:00
Member
Copy Link
Copy Source
No description provided.
johannes.vos added this to the mvp-frontend milestone 2026-05-15 17:26:47 +02:00
johannes.vos added the
area
startpage
prio
low
area/global
type
feature
 labels 2026-05-15 17:26:47 +02:00
johannes.vos self-assigned this 2026-05-15 17:26:47 +02:00
johannes.vos added this to the MVP Frontend project 2026-05-15 17:26:47 +02:00
johannes.vos added 4 commits 2026-05-15 17:26:47 +02:00
add svg file 31dd40e1d7
feat: replace h1 text with logo image in SearchView ae639dbe71
feat: replace text with logo image in Navbar 5eddee4d4d
change height of logo d7246b9aab
johannes.vos moved this to Review in MVP Frontend on 2026-05-15 17:29:51 +02:00
jakob.scheid reviewed 2026-05-15 18:01:02 +02:00
jakob.scheid reviewed 2026-05-15 18:01:31 +02:00
src/views/SearchView.vue Outdated
@@ -38,2 +34,2 @@
</span>
</header>
<header class="global-header">
<img src="@/assets/logo.svg" alt="Seekra" class="header-logo" />
jakob.scheid commented 2026-05-15 18:01:31 +02:00
Owner
Copy Link
Copy Source

Using an alias in an <img> src usually works. But there is no guarantee that it will actually work 100% of the time. That is why I would ask you to import the image in the <script> (such as import logo from '@/assets/logo.svg';) and using it dynamically with :src (such as :src="logo").

Using an alias in an `<img>` `src` usually works. But there is no guarantee that it will actually work 100% of the time. That is why I would ask you to import the image in the `<script>` (such as `import logo from '@/assets/logo.svg';`) and using it dynamically with `:src` (such as `:src="logo"`).
johannes.vos commented 2026-05-15 18:23:58 +02:00
Author
Member
Copy Link
Copy Source

Is done!

Is done!
jakob.scheid marked this conversation as resolved
jakob.scheid reviewed 2026-05-15 18:02:29 +02:00
src/features/nav/components/Navbar.vue Outdated
@@ -21,3 +21,3 @@
<nav class="global-nav">
<RouterLink to="/" class="link button link">
<span id="logo">Seekra</span>
<img src="@/assets/logo.svg" alt="Seekra" class="nav-logo" />
jakob.scheid commented 2026-05-15 18:02:29 +02:00
Owner
Copy Link
Copy Source

Please see my comment in src/views/SearchView.vue.

Please see my comment in `src/views/SearchView.vue`.
johannes.vos commented 2026-05-15 18:23:49 +02:00
Author
Member
Copy Link
Copy Source

Is done!

Is done!
jakob.scheid marked this conversation as resolved
jakob.scheid added 1 commit 2026-05-15 18:08:53 +02:00
Merge branch 'main' into feature/use-logo 6e3ef7aae0
johannes.vos added 2 commits 2026-05-15 18:23:18 +02:00
fix: import logo in SearchView and use :src binding 8eab67b78f
fix: import logo in SearchView and use :src binding 22e50adaa5
jakob.scheid added 1 commit 2026-05-15 18:52:26 +02:00
Remove comment 792b4b80b8
jakob.scheid approved these changes 2026-05-15 18:52:56 +02:00
jakob.scheid merged commit ceda686d03 into main 2026-05-15 18:53:04 +02:00
jakob.scheid deleted branch feature/use-logo 2026-05-15 18:53:04 +02:00
jakob.scheid moved this to Done in MVP Frontend on 2026-05-15 19:22:41 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
jakob.scheid
Labels
Clear labels
area/global
area
search-results
area
settings
area
startpage
prio
critical
prio
high
prio
low
prio
medium
type
bug
type
chore
type
docs
type
feature
type
refactor
type
testing
type/urgent
No Label area/global
area
startpage
prio
low
type
feature
Milestone
No items
No Milestone mvp-frontend
Projects
Clear projects
No project MVP Frontend
Assignees
Clear assignees
jakob.gregory (Jakob Gregory) jakob.scheid (Jakob Scheid) johannes.vos (Johannes D. Vos)
No Assignees johannes.vos
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Seekra/frontend#52
Delete Branch "feature/use-logo"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?