Seekra/frontend
3
2
Fork 0
generated from Seekra/repository-template
Code Issues 4 Pull Requests Actions Packages Projects 1 Releases Wiki Activity

Add header and footer #4

Merged
jakob.scheid merged 2 commits from feature/ui-base into main 2026-05-02 16:54:03 +02:00
Conversation 5 Commits 2 Files Changed 1
+6
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 1fd1fbba57 - Show all commits
src/index.html
+6
View File
@@ -22,5 +22,11 @@ limitations under the License.
<title>Seekra</title>
</head>
<body>
<header>
<h1>Seekra</h1>
<div>
johannes.vos commented 2026-05-02 15:56:20 +02:00
Review
Copy Link
Copy Source

(Subtitle) is missing

<h3> (Subtitle) is missing
jakob.scheid commented 2026-05-02 16:41:38 +02:00
Review
Copy Link
Copy Source

I intentionally omitted the stylesheets because they are semantically part of the UI base.

I intentionally omitted the stylesheets because they are semantically part of the UI ***base***.
jakob.scheid commented 2026-05-02 16:43:14 +02:00
Review
Copy Link
Copy Source

Furthermore, the search field is not part of the UI base

Furthermore, the search field is not part of the UI ***base***
johannes.vos commented 2026-05-02 16:47:47 +02:00
Review
Copy Link
Copy Source

But in my suggestion there was a style, it is for the main and thats why there shoud be the style and search bar

But in my suggestion there was a style, it is for the main and thats why there shoud be the style and search bar
jakob.scheid commented 2026-05-02 16:49:49 +02:00
Review
Copy Link
Copy Source

I think it's better to to this in a separate branch.

I think it's better to to this in a separate branch.
johannes.vos commented 2026-05-02 16:51:11 +02:00
Review
Copy Link
Copy Source

But we alerady did it

But we alerady did it
Built to search.
</div>
</header>
</body>
</html>