Seekra/frontend
3
2
Fork 0
generated from Seekra/repository-template
Code Issues 4 Pull Requests Actions Packages Projects 1 Releases Wiki Activity

Add header and footer #4

Merged
jakob.scheid merged 2 commits from feature/ui-base into main 2026-05-02 16:54:03 +02:00
Conversation 5 Commits 2 Files Changed 1
+10
jakob.scheid commented 2026-05-02 15:39:18 +02:00
Owner
Copy Link
Copy Source
No description provided.
jakob.scheid added 2 commits 2026-05-02 15:39:18 +02:00
Add header 1fd1fbba57
Add footer 3b3614bd62
johannes.vos commented 2026-05-02 15:54:54 +02:00
Member
Copy Link
Copy Source

Style is missing

Style is missing
johannes.vos requested changes 2026-05-02 15:55:14 +02:00
Dismissed
johannes.vos left a comment
Member
Copy Link
Copy Source

The Search Input Field and Style is missing

The Search Input Field and Style is missing
johannes.vos requested changes 2026-05-02 16:34:20 +02:00
Dismissed
src/index.html
@@ -24,1 +24,4 @@
<body>
<header>
<h1>Seekra</h1>
<div>
johannes.vos commented 2026-05-02 15:56:20 +02:00
Member
Copy Link
Copy Source

(Subtitle) is missing

<h3> (Subtitle) is missing
jakob.scheid commented 2026-05-02 16:41:38 +02:00
Author
Owner
Copy Link
Copy Source

I intentionally omitted the stylesheets because they are semantically part of the UI base.

I intentionally omitted the stylesheets because they are semantically part of the UI ***base***.
jakob.scheid commented 2026-05-02 16:43:14 +02:00
Author
Owner
Copy Link
Copy Source

Furthermore, the search field is not part of the UI base

Furthermore, the search field is not part of the UI ***base***
johannes.vos commented 2026-05-02 16:47:47 +02:00
Member
Copy Link
Copy Source

But in my suggestion there was a style, it is for the main and thats why there shoud be the style and search bar

But in my suggestion there was a style, it is for the main and thats why there shoud be the style and search bar
jakob.scheid commented 2026-05-02 16:49:49 +02:00
Author
Owner
Copy Link
Copy Source

I think it's better to to this in a separate branch.

I think it's better to to this in a separate branch.
johannes.vos commented 2026-05-02 16:51:11 +02:00
Member
Copy Link
Copy Source

But we alerady did it

But we alerady did it
jakob.gregory approved these changes 2026-05-02 16:42:09 +02:00
johannes.vos approved these changes 2026-05-02 16:53:16 +02:00
jakob.scheid merged commit 0eb74a78d3 into main 2026-05-02 16:54:03 +02:00
jakob.scheid deleted branch feature/ui-base 2026-05-02 16:54:30 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
jakob.gregory
johannes.vos
Labels
Clear labels
area/global
area
search-results
area
settings
area
startpage
prio
critical
prio
high
prio
low
prio
medium
type
bug
type
chore
type
docs
type
feature
type
refactor
type
testing
type/urgent
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
jakob.gregory (Jakob Gregory) jakob.scheid (Jakob Scheid) johannes.vos (Johannes D. Vos)
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Seekra/frontend#4
Delete Branch "feature/ui-base"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?