Seekra/frontend
3
3
Fork 0
generated from Seekra/repository-template
Code Issues 9 Pull Requests Actions Packages Projects 1 Releases 1 Wiki Activity

Load the default language on startup #133

Merged
jakob.scheid merged 3 commits from fix/load-default-language into main 2026-07-21 19:59:06 +02:00
Conversation 3 Commits 3 Files Changed 1
+14 -13
jakob.gregory commented 2026-07-21 19:09:58 +02:00
Member
Copy Link
Copy Source

Summary

  • always load the fallback language on application startup
  • load the user's selected language afterwards if it differs from the fallback language
  • ensure fallback translations are available immediately during the initial load

Related issues

Closes: #130

## Summary - always load the fallback language on application startup - load the user's selected language afterwards if it differs from the fallback language - ensure fallback translations are available immediately during the initial load ## Related issues Closes: #130
jakob.gregory added this to the 0.1.0 milestone 2026-07-21 19:09:58 +02:00
jakob.gregory added the Kind/BugArea/Global labels 2026-07-21 19:09:58 +02:00
jakob.gregory added this to the Project Board project 2026-07-21 19:09:58 +02:00
jakob.gregory added 1 commit 2026-07-21 19:09:59 +02:00
fix(i18n): load default language on startup d4363f7515
jakob.gregory moved this to Review in Project Board on 2026-07-21 19:10:19 +02:00
jakob.scheid reviewed 2026-07-21 19:12:51 +02:00
src/main.js Outdated
@@ -27,1 +27,3 @@
await loadLanguage(getCurrentLanguage())
await loadLanguage(fallbackLocale)
const currentLanguage = getCurrentLanguage()
jakob.scheid commented 2026-07-21 19:12:51 +02:00
Owner
Copy Link
Copy Source

This check is not necessary. loadLanguage already checks whether a language has already been loaded. If the language preferred by the user is the same as the fallback language, it is not redundantly fetched.

This check is not necessary. `loadLanguage` already checks whether a language has already been loaded. If the language preferred by the user is the same as the fallback language, it is not redundantly fetched.
jakob.scheid marked this conversation as resolved
jakob.scheid reviewed 2026-07-21 19:13:28 +02:00
src/main.js Outdated
@@ -25,3 +25,3 @@
(async () => {
await loadLanguage(getCurrentLanguage())
await loadLanguage(fallbackLocale)
jakob.scheid commented 2026-07-21 19:13:28 +02:00
Owner
Copy Link
Copy Source

Please use a semicolon at the end of the line.

Please use a semicolon at the end of the line.
jakob.gregory commented 2026-07-21 19:15:20 +02:00
Author
Member
Copy Link
Copy Source

I will fix that.

I will fix that.
jakob.scheid marked this conversation as resolved
jakob.gregory added 1 commit 2026-07-21 19:14:54 +02:00
Merge branch 'main' into fix/load-default-language 2060134563
jakob.gregory added 1 commit 2026-07-21 19:19:32 +02:00
fix(i18n): always load fallback language on startup f343d99406
jakob.scheid approved these changes 2026-07-21 19:58:52 +02:00
jakob.scheid merged commit d5f80eba67 into main 2026-07-21 19:59:06 +02:00
jakob.scheid deleted branch fix/load-default-language 2026-07-21 19:59:06 +02:00
jakob.scheid moved this to Done in Project Board on 2026-07-21 19:59:31 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
jakob.scheid
Labels
Clear labels
Area/Global
A global issue or pull request
 Area/Search Results
An issue or pull requests related to the search results feature
 Area/Settings
The issue or pull request is related to the settings
 Area/Start page
Related to the start page
 Compat/Breaking
Breaking change that will not be backward compatible
 Kind/Bug
Something is not working
 Kind/Chore
Chore and maintainerance
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Refactor
Refactoring code
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
 Kind/Urgent
The issue or pull request is urgent
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Will Not Fix
3
This issue will not be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No labels Area/Global Kind/Bug
Milestone
No items
No Milestone 0.1.0
Projects
Clear projects
No projects
Project Board
Done
Assignees
Clear assignees
jakob.gregory (Jakob Gregory) jakob.scheid (Jakob Scheid) johannes.vos (Johannes Vos)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Seekra/frontend#133