Seekra/frontend
3
2
Fork 0
generated from Seekra/repository-template
Code Issues 4 Pull Requests Actions Packages Projects 1 Releases Wiki Activity

Language switch button unit test #108

Merged
jakob.scheid merged 23 commits from testing/language-switch into main 2026-06-04 13:46:17 +02:00
Conversation 8 Commits 23 Files Changed 2
+116 -1
johannes.vos commented 2026-06-04 13:02:10 +02:00
Member
Copy Link
Copy Source

Language switch button unit test

Add a unit test for the language switch component (src/features/i18n/components/LanguageSwitchButton.vue).

Summary

  • test cases for initial closed state and correct ARIA attributes
  • test cases for opening the dropdown via button click
  • data-driven test matrix (test.for) covering LTR and RTL language selection (including localStorage and HTML document attributes)
  • test case for closing the dropdown when clicking outside the component

Related issues

Closes: #86

# Language switch button unit test Add a unit test for the language switch component (src/features/i18n/components/LanguageSwitchButton.vue). ## Summary * test cases for initial closed state and correct ARIA attributes * test cases for opening the dropdown via button click * data-driven test matrix (test.for) covering LTR and RTL language selection (including localStorage and HTML document attributes) * test case for closing the dropdown when clicking outside the component ## Related issues Closes: #86
johannes.vos added this to the testing-ready milestone 2026-06-04 13:02:10 +02:00
johannes.vos added the
area
settings
prio
high
type
testing
 labels 2026-06-04 13:02:10 +02:00
johannes.vos self-assigned this 2026-06-04 13:02:10 +02:00
johannes.vos added this to the MVP Frontend project 2026-06-04 13:02:10 +02:00
johannes.vos moved this to Review in MVP Frontend on 2026-06-04 13:02:39 +02:00
jakob.scheid commented 2026-06-04 13:11:05 +02:00
Owner
Copy Link
Copy Source

Why did you put it into src/utils/__tests__/ instead of src/features/i18n/components/__tests__/?

Why did you put it into `src/utils/__tests__/` instead of `src/features/i18n/components/__tests__/`?
jakob.scheid reviewed 2026-06-04 13:14:35 +02:00
src/utils/__tests__/LanguageSwitchButton.test.js Outdated
@@ -0,0 +1,114 @@
/*
jakob.scheid commented 2026-06-04 13:14:35 +02:00
Owner
Copy Link
Copy Source

Can you please use the variant without the * indentation? That is more common, cleaner and better for automated tools.

Can you please use the variant without the ` * ` indentation? That is more common, cleaner and better for automated tools.
jakob.scheid marked this conversation as resolved
jakob.scheid reviewed 2026-06-04 13:15:12 +02:00
src/utils/__tests__/LanguageSwitchButton.test.js Outdated
@@ -0,0 +47,4 @@
document.documentElement.dir = '';
});
test('renders correctly with initial state closed', () => {
jakob.scheid commented 2026-06-04 13:15:12 +02:00
Owner
Copy Link
Copy Source

Could you please fix the indentation to make it more readable?

Could you please fix the indentation to make it more readable?
jakob.scheid marked this conversation as resolved
jakob.scheid commented 2026-06-04 13:19:52 +02:00
Owner
Copy Link
Copy Source

The test does not work. Maybe you forgot adding @vue/test-utils to the devDependencies section in package.json?

The test does not work. Maybe you forgot adding `@vue/test-utils` to the `devDependencies` section in `package.json`?
johannes.vos added a new dependency 2026-06-04 13:30:34 +02:00
#66 Code style is not consistent
johannes.vos removed a dependency 2026-06-04 13:30:50 +02:00
#66 Code style is not consistent
johannes.vos commented 2026-06-04 13:31:25 +02:00
Author
Member
Copy Link
Copy Source

The test does not work. Maybe you forgot adding @vue/test-utils to the devDependencies section in package.json?

It workes for me.

> The test does not work. Maybe you forgot adding `@vue/test-utils` to the `devDependencies` section in `package.json`? It workes for me.
johannes.vos commented 2026-06-04 13:32:28 +02:00
Author
Member
Copy Link
Copy Source

I will improve it!

**I will improve it!**
johannes.vos marked the pull request as work in progress 2026-06-04 13:32:35 +02:00
johannes.vos commented 2026-06-04 13:35:13 +02:00
Author
Member
Copy Link
Copy Source

@jakob.scheid Please try again.

@jakob.scheid Please try again.
johannes.vos marked the pull request as ready for review 2026-06-04 13:38:48 +02:00
jakob.scheid added 10 commits 2026-06-04 13:43:10 +02:00
add LanguageSwitchButton.test.js file - empty ebe21f7f4d
add license 54ffaf73e3
add imports d6700d6965
mock i18n and icon dependencies for language switch a6194bb874
initialize language switch test suite with beforeEach setup 02af96a07d
verify initial closed state and toggle opening of dropdown 0bb0f23347
assert language selection updates localStorage and HTML attributes 98cc6b7556
validate dropdown closes on click outside the component 88634e10cd
chore: add @vue/test-utils to devDependencies 3a07b0482f
test: move language switch test, fix header comments and code indentation 27f696247d
jakob.scheid force-pushed testing/language-switch from 918d6768e8 to 27f696247d 2026-06-04 13:43:10 +02:00 Compare
jakob.scheid added 12 commits 2026-06-04 13:44:35 +02:00
add LanguageSwitchButton.test.js file - empty 5c3d7ce535
add license d5b76b0a17
add imports baa1f6ed44
mock i18n and icon dependencies for language switch a97ee3c660
initialize language switch test suite with beforeEach setup 1c3175a3e4
verify initial closed state and toggle opening of dropdown e8cb978a61
assert language selection updates localStorage and HTML attributes dc1caac2ed
validate dropdown closes on click outside the component 521f1becb4
chore: add @vue/test-utils to devDependencies 924698df24
test: move language switch test, fix header comments and code indentation 918d6768e8
test(language-switch-button): move test file to the correct directory eb892d9725
Merge remote-tracking branch 'refs/remotes/origin/testing/language-switch' into testing/language-switch a5dede3485
jakob.scheid added 1 commit 2026-06-04 13:45:26 +02:00
test(language-switch-button): remove redundant test file dc4c47e2ef
jakob.scheid approved these changes 2026-06-04 13:46:06 +02:00
jakob.scheid left a comment
Owner
Copy Link
Copy Source

Very nice.

Very nice.
jakob.scheid merged commit 5122d93072 into main 2026-06-04 13:46:17 +02:00
jakob.scheid deleted branch testing/language-switch 2026-06-04 13:46:17 +02:00
jakob.scheid moved this to Done in MVP Frontend on 2026-06-04 13:46:25 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
jakob.scheid
Labels
Clear labels
area/global
area
search-results
area
settings
area
startpage
prio
critical
prio
high
prio
low
prio
medium
type
bug
type
chore
type
docs
type
feature
type
refactor
type
testing
type/urgent
No Label
area
settings
prio
high
type
testing
Milestone
No items
No Milestone testing-ready
Projects
Clear projects
No project MVP Frontend
Assignees
Clear assignees
jakob.gregory (Jakob Gregory) jakob.scheid (Jakob Scheid) johannes.vos (Johannes D. Vos)
No Assignees johannes.vos
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Seekra/frontend#108
Delete Branch "testing/language-switch"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?