jCloud/jcloud-docsgen
2
1 Fork 0
generated from jCloud/repository-template
Code Issues 3 Pull Requests Actions Packages Projects 1 Releases 13 Wiki Activity

Fix(python-generator): make generated signatures compliant with PEP 8 #35

Merged
jakob.scheid merged 3 commits from fix/python-signatures-pep-8-compliance into main 2026-09-22 16:15:36 +02:00
Conversation 0 Commits 3 Files Changed 10
+336 -25
jakob.scheid commented 2026-09-22 16:08:33 +02:00
Owner
Copy link
Copy source

Signatures PEP 8 compliance

This pull request makes argument default values in Python function signatures compliant with PEP 8. Previously, the = character has always been surrounded with a space. Now, it is only if there is a type hint.

The test cases were updated to the new behavior and there are new ones to test it additionally.

There is a new entry for this change in the changelog.

Related issues

Closes #30

# Signatures PEP 8 compliance This pull request makes argument default values in Python function signatures compliant with PEP 8. Previously, the `=` character has always been surrounded with a space. Now, it is only if there is a type hint. The test cases were updated to the new behavior and there are new ones to test it additionally. There is a new entry for this change in the changelog. ## Related issues Closes #30
jakob.scheid added this to the 0.2.0 milestone 2026-09-22 16:08:33 +02:00
jakob.scheid added the Kind/BugKind/Enhancement
Priority
Medium
3
 labels 2026-09-22 16:08:33 +02:00
jakob.scheid added this to the Project Board project 2026-09-22 16:08:33 +02:00
jakob.scheid added 1 commit 2026-09-22 16:08:34 +02:00
fix(python-generator): make signatures compliant with PEP 8 cc786a6c69 
The '=' character at a parameter in the signature was surrounded with
spaces previously. That is no longer the case, unless there is a type
hint.
jakob.scheid moved this to Review in Project Board on 2026-09-22 16:08:43 +02:00
jakob.scheid marked the pull request as work in progress 2026-09-22 16:08:53 +02:00
jakob.scheid marked the pull request as ready for review 2026-09-22 16:10:14 +02:00
jakob.scheid added the Kind/Documentation label 2026-09-22 16:10:23 +02:00
jakob.scheid added 2 commits 2026-09-22 16:13:54 +02:00
test(python-generator): update tests for PEP 8 compliance 17c5e4938f 
Updated test cases to the new default value PEP 8 compliance and added
new test cases to test the new behavior.
docs(changelog): add Python signatures PEP 8 compliance entry 06802c96f6 
Added a changelog entry for the PEP 8 compliance of Python function
signatures default values.
jakob.scheid force-pushed fix/python-signatures-pep-8-compliance from 045167098f to 06802c96f6 2026-09-22 16:13:54 +02:00 Compare
jakob.scheid merged commit 63cef6f641 into main 2026-09-22 16:15:36 +02:00
jakob.scheid deleted branch fix/python-signatures-pep-8-compliance 2026-09-22 16:15:36 +02:00
jakob.scheid moved this to Done in Project Board on 2026-09-22 16:15:42 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Compat/Breaking
Breaking change that will not be backward compatible
 Kind/Bug
Something is not working
 Kind/Chore
Chore and maintenance
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Refactor
Refactoring code
 Kind/Security
This is security issue
 Kind/Style
Code style changes
 Kind/Testing
Issue or pull request related to testing
 Kind/Urgent
The issue or pull request is urgent
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Medium
3
The priority is medium
Priority
Low
4
The priority is low
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Will Not Fix
3
This issue won't be fixed
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
Status
Abandoned
3
Somebody has started to work on this but abandoned work
No labels Kind/Bug Kind/Documentation Kind/Enhancement
Priority
Medium
3
Milestone
No items
No Milestone 0.2.0
Projects
Clear projects
No projects
Project Board
Done
Assignees
Clear assignees
jakob.scheid (Jakob Scheid) jcloud-bot (jCloudBot) Bot
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: jCloud/jcloud-docsgen#35