Seekra/frontend
3
2
Fork 0
generated from Seekra/repository-template
Code Issues 4 Pull Requests Actions Packages Projects 1 Releases Wiki Activity

add settings configuration parser #78

Merged
jakob.scheid merged 20 commits from feature/settings-config-parser into main 2026-05-29 14:03:15 +02:00
Conversation 8 Commits 20 Files Changed 5
+15 -17
1 changed files with 15 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 5d2064134b - Show all commits
src/features/settings/utils/settingsValidator.js
+15 -17
View File
@@ -57,23 +57,21 @@ function validateEntry(entry, path) {
assertString(entry.name, `${path}.name`); assertString(entry.name, `${path}.name`);
assertString(entry.i18n, `${path}.i18n`); assertString(entry.i18n, `${path}.i18n`);
if (entry.default === undefined) { if (entry.default !== undefined) {
jakob.scheid marked this conversation as resolved Outdated
jakob.scheid commented 2026-05-26 12:09:22 +02:00
Outdated
Review
Copy Link
Copy Source

Not every setting does need a default value. I suggest omitting this check.

Not every setting does need a default value. I suggest omitting this check.
throw new Error(`[settings] "${path}.default" is required`); if (entry.type === 'bool' && typeof entry.default !== 'boolean') {
} throw new Error(`[settings] "${path}.default" must be a boolean`);
}
if (entry.type === 'bool' && typeof entry.default !== 'boolean') { if (entry.type === 'number' && typeof entry.default !== 'number') {
throw new Error(`[settings] "${path}.default" must be a boolean`); throw new Error(`[settings] "${path}.default" must be a number`);
} }
if (entry.type === 'number' && typeof entry.default !== 'number') { if (entry.type === 'string' && typeof entry.default !== 'string') {
throw new Error(`[settings] "${path}.default" must be a number`); throw new Error(`[settings] "${path}.default" must be a string`);
} }
if (entry.type === 'string' && typeof entry.default !== 'string') { if (entry.type === 'selection') {
throw new Error(`[settings] "${path}.default" must be a string`); validateSelectionOptions(entry.options, path);
} if (typeof entry.allowMultiple !== 'boolean') {
if (entry.type === 'selection') { throw new Error(`[settings] "${path}.allowMultiple" must be a boolean`);
validateSelectionOptions(entry.options, path); }
if (typeof entry.allowMultiple !== 'boolean') {
throw new Error(`[settings] "${path}.allowMultiple" must be a boolean`);
} }
jakob.scheid marked this conversation as resolved Outdated
jakob.scheid commented 2026-05-26 12:11:06 +02:00
Outdated
Review
Copy Link
Copy Source

I think it should have a default value (false) that is used if it is not specified.

I think it should have a default value (`false`) that is used if it is not specified.
} }
} }