Seekra/frontend
3
2
Fork 0
generated from Seekra/repository-template
Code Issues 4 Pull Requests Actions Packages Projects 1 Releases Wiki Activity

Add NotFound.vue #48 #50

Merged
jakob.scheid merged 22 commits from feature/not-found-page into main 2026-05-14 16:21:30 +02:00
Conversation 8 Commits 22 Files Changed 3
+9 -21
1 changed files with 9 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit fb5985dcb1 - Show all commits
src/views/NotFound.vue
+4 -16
View File
@@ -1,26 +1,14 @@
<script setup>
import Searchbar from '../features/search/components/Searchbar.vue';
import { ref } from 'vue';
import { useRouter } from 'vue-router';
const router = useRouter();
const searchQuery = ref('');
const submitSearch = function () {
};
</script>
<template> <template>
<div class="search-content">
jakob.scheid marked this conversation as resolved Outdated
jakob.scheid commented 2026-05-14 13:20:28 +02:00
Outdated
Review
Copy Link
Copy Source

Do not use a container .search-content in a not found page.

Do not use a container *.search-content* in a not found page.
<header class="global-header"> <header class="global-header">
jakob.scheid marked this conversation as resolved Outdated
jakob.scheid commented 2026-05-14 13:22:08 +02:00
Outdated
Review
Copy Link
Copy Source

The not found page should be minimal, so omit the header. The navigation bar already contains Seekra.

The not found page should be minimal, so omit the header. The navigation bar already contains *Seekra*.
<h1>Seekra</h1> <h1>Seekra</h1>
<span class="slogan"> <span class="slogan">
jakob.scheid marked this conversation as resolved Outdated
jakob.scheid commented 2026-05-14 13:21:22 +02:00
Outdated
Review
Copy Link
Copy Source

No HTTP status code. That is confusing for people who are not familiar with technology.

No HTTP status code. That is confusing for people who are not familiar with technology.
ERROR: 404 Not Found ERROR 404: Page Not Found
jakob.scheid marked this conversation as resolved Outdated
jakob.scheid commented 2026-05-14 13:19:17 +02:00
Outdated
Review
Copy Link
Copy Source

Do not write ERROR uppercase.

Do not write *ERROR* uppercase.
</span> </span>
</header> </header>
</div>
</template> </template>
<style scoped> <style scoped>
.global-header { .global-header {
text-align: center; text-align: center;
jakob.scheid marked this conversation as resolved Outdated
jakob.scheid commented 2026-05-14 13:18:20 +02:00
Outdated
Review
Copy Link
Copy Source

Copying styles is a very bad idea. Nothing should be redundant.

Copying styles is a very bad idea. Nothing should be redundant.