Seekra/frontend
3
2
Fork 0
generated from Seekra/repository-template
Code Issues 4 Pull Requests Actions Packages Projects 1 Releases Wiki Activity

Move the search bar in the search results view into the navigation bar #82

Merged
jakob.scheid merged 10 commits from chore/searchbar into main 2026-05-29 18:30:06 +02:00
Conversation 4 Commits 10 Files Changed 2
+28 -11
johannes.vos commented 2026-05-29 16:00:13 +02:00
Member
Copy Link
Copy Source

Move the search bar in the search results view into the navigation bar

Summary:

  • Move search bar into navbar when the search results view is visible

Related issues

Closes: #64

# Move the search bar in the search results view into the navigation bar ## Summary: - Move search bar into navbar when the search results view is visible ## Related issues Closes: #64
johannes.vos added 5 commits 2026-05-29 16:00:13 +02:00
create empty Searchbar-SearchResults.vue file 1421789e43
move Searchbar-SearchResults.vue file to nav/components a33bc047fa
copy/paste searchbar.vue code to searchbar-searchresults.vue (placeholder) 325551d253
feat(navbar): show search input only on search results page 98c954e361
chore(search-results): clean up unused search props and imports 926010f128
johannes.vos added the
area
search-results
prio
low
type
chore
 labels 2026-05-29 16:00:21 +02:00
johannes.vos added this to the mvp-frontend milestone 2026-05-29 16:00:23 +02:00
johannes.vos added this to the MVP Frontend project 2026-05-29 16:00:24 +02:00
johannes.vos self-assigned this 2026-05-29 16:00:27 +02:00
johannes.vos moved this to Review in MVP Frontend on 2026-05-29 16:00:35 +02:00
jakob.scheid reviewed 2026-05-29 16:07:21 +02:00
src/features/nav/components/Navbar.vue Outdated
@@ -18,3 +20,4 @@
import ColorSchemeButton from '@/features/colorScheme/components/ColorSchemeButton.vue';
import LanguageSwitchButton from '@/features/i18n/components/LanguageSwitchButton.vue';
import logo from '@/assets/images/logo.svg';
import Searchbar from '@/features/nav/components/Searchbar-SearchResults.vue';
jakob.scheid commented 2026-05-29 16:07:21 +02:00
Owner
Copy Link
Copy Source

Usually, pascal case (PascalCase) is used when naming Vue.js components.

Usually, pascal case (PascalCase) is used when naming Vue.js components.
jakob.scheid marked this conversation as resolved
jakob.scheid reviewed 2026-05-29 16:08:09 +02:00
src/features/search/views/SearchResultsView.vue Outdated
@@ -31,3 +24,1 @@
<div class="main-content-padding">
<Searchbar class="search-bar" v-model="searchQueryModel" auto-submit />
<div class="main-content-padding">
jakob.scheid commented 2026-05-29 16:08:09 +02:00
Owner
Copy Link
Copy Source

Could you please remove these whitespaces?

Could you please remove these whitespaces?
jakob.scheid marked this conversation as resolved
jakob.scheid commented 2026-05-29 16:11:41 +02:00
Owner
Copy Link
Copy Source

Why did you create a new component for the search bar and copied the content of the search bar component into that instead of using the search bar component?

Why did you create a new component for the search bar and copied the content of the search bar component into that instead of using the search bar component?
jakob.scheid added 1 commit 2026-05-29 16:18:42 +02:00
Remove unnecessary whitespaces f72a2bf2b1
jakob.scheid changed title from Move Searchbar in SearchResultView.vue in the NavBar to Move the search bar in the search results view into the navigation bar 2026-05-29 16:20:11 +02:00
jakob.scheid added 2 commits 2026-05-29 18:14:18 +02:00
Remove redundant search bar component 2fd010ddfa
Set navbar height to prevent layout shifting when the search bar is shown when the search results view is visible 7a7f698b44
jakob.scheid added 1 commit 2026-05-29 18:16:49 +02:00
Increase navbar vertical padding 295bfc19e6
jakob.scheid added 1 commit 2026-05-29 18:28:56 +02:00
Make search query model cleaner d461da90f2
jakob.scheid approved these changes 2026-05-29 18:29:47 +02:00
jakob.scheid merged commit 3b8c387c44 into main 2026-05-29 18:30:06 +02:00
jakob.scheid deleted branch chore/searchbar 2026-05-29 18:30:06 +02:00
jakob.scheid moved this to Done in MVP Frontend on 2026-05-29 18:33:37 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
jakob.scheid
Labels
Clear labels
area/global
area
search-results
area
settings
area
startpage
prio
critical
prio
high
prio
low
prio
medium
type
bug
type
chore
type
docs
type
feature
type
refactor
type
testing
type/urgent
No Label
area
search-results
prio
low
type
chore
Milestone
No items
No Milestone mvp-frontend
Projects
Clear projects
No project MVP Frontend
Assignees
Clear assignees
jakob.gregory (Jakob Gregory) jakob.scheid (Jakob Scheid) johannes.vos (Johannes D. Vos)
No Assignees johannes.vos
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Seekra/frontend#82
Delete Branch "chore/searchbar"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?