Seekra/frontend
3
2
Fork 0
generated from Seekra/repository-template
Code Issues 4 Pull Requests Actions Packages Projects 1 Releases Wiki Activity

Add more Languages and switch button #70

Merged
jakob.scheid merged 22 commits from feature/add-languages into main 2026-05-22 17:19:25 +02:00
Conversation 13 Commits 22 Files Changed 11
+387 -9
johannes.vos commented 2026-05-20 20:36:36 +02:00
Member
Copy Link
Copy Source

Closes: #69

Closes: #69
johannes.vos added this to the mvp-frontend milestone 2026-05-20 20:36:36 +02:00
johannes.vos added the area/global
type
feature
prio
low
 labels 2026-05-20 20:36:36 +02:00
johannes.vos self-assigned this 2026-05-20 20:36:36 +02:00
johannes.vos added this to the MVP Frontend project 2026-05-20 20:36:36 +02:00
johannes.vos added 8 commits 2026-05-20 20:36:36 +02:00
Add emty langauge json files a7ff5e2bf4
Add suported languages in i18n.js 5a04e2a2f1
add emty LangaugeSwitchButton.bue file 010d29c74e
add content in langauge files 7c8cf6406d
add switch button 6fa3ba6298
remove lanugages cb42c9d368
implement switch button dc532d3848
save lanugage in local storage 46d92675eb
johannes.vos moved this to Review in MVP Frontend on 2026-05-20 20:36:59 +02:00
jakob.scheid reviewed 2026-05-21 13:12:21 +02:00
src/features/language/components/LanguageSwitchButton.vue Outdated
@@ -0,0 +23,4 @@
const isOpen = ref(false);
const languages = [
jakob.scheid commented 2026-05-21 13:12:21 +02:00
Owner
Copy Link
Copy Source

Please do not use hard-coded values. All strings should be in the locale files.

Please do not use hard-coded values. All strings should be in the locale files.
jakob.scheid marked this conversation as resolved
jakob.scheid reviewed 2026-05-21 13:13:16 +02:00
src/features/language/components/LanguageSwitchButton.vue Outdated
@@ -0,0 +36,4 @@
() => languages.find(l => l.code === locale.value) ?? languages[0]
);
async function selectLanguage(code) {
jakob.scheid commented 2026-05-21 13:13:16 +02:00
Owner
Copy Link
Copy Source

I think an extra function that simply calls another function is not necessary.

I think an extra function that simply calls another function is not necessary.
jakob.scheid marked this conversation as resolved
jakob.scheid reviewed 2026-05-21 13:14:09 +02:00
src/features/language/components/LanguageSwitchButton.vue Outdated
@@ -0,0 +49,4 @@
}
function closeOnBlur() {
// Kleines Delay damit Click auf Option noch registriert wird
jakob.scheid commented 2026-05-21 13:14:09 +02:00
Owner
Copy Link
Copy Source

I ask you to speak English.

I ask you to speak English.
jakob.scheid marked this conversation as resolved
jakob.scheid commented 2026-05-21 13:18:38 +02:00
Owner
Copy Link
Copy Source

Should we say „Sie“ or „Du“ in German?

Should we say „Sie“ or „Du“ in German?
jakob.scheid reviewed 2026-05-21 15:04:16 +02:00
jakob.scheid left a comment
Owner
Copy Link
Copy Source

I suggest naming the directory src/features/i18n//src/features/internationalization/src/features/locale_preferences.

I suggest naming the directory `src/features/i18n/`/`src/features/internationalization`/`src/features/locale_preferences`.
jakob.scheid reviewed 2026-05-21 15:06:12 +02:00
src/features/language/components/LanguageSwitchButton.vue Outdated
@@ -0,0 +40,4 @@
await loadLanguage(code);
localStorage.setItem('locale', code);
document.documentElement.lang = code;
document.documentElement.dir = code === 'ar' ? 'rtl' : 'ltr';
jakob.scheid commented 2026-05-21 15:06:12 +02:00
Owner
Copy Link
Copy Source

Consider that Arabic isn't the only language written from right to left.

Consider that Arabic isn't the only language written from right to left.
jakob.scheid marked this conversation as resolved
jakob.scheid requested changes 2026-05-21 15:09:19 +02:00
Dismissed
jakob.scheid left a comment
Owner
Copy Link
Copy Source

When you open the dropdown menu, select a language, and then click on it again, it closes immediately.

When you open the dropdown menu, select a language, and then click on it again, it closes immediately.
jakob.scheid reviewed 2026-05-21 15:39:56 +02:00
src/features/language/components/LanguageSwitchButton.vue Outdated
@@ -0,0 +24,4 @@
const isOpen = ref(false);
const languages = [
{ code: 'en', label: 'English', flag: '🇬🇧' },
jakob.scheid commented 2026-05-21 15:39:56 +02:00
Owner
Copy Link
Copy Source

You do not need lines const currentLanguage = … if you simply write

const languages = {
    'en': {
        label: 'English',
        flag: '🇬🇧'
    },
    …
}
You do not need lines `const currentLanguage = …` if you simply write ``` const languages = { 'en': { label: 'English', flag: '🇬🇧' }, … } ```
jakob.scheid marked this conversation as resolved
jakob.scheid added 1 commit 2026-05-21 15:45:30 +02:00
Rename 'src/features/language/' to 'src/features/i18n/' 90f99e4240
jakob.scheid commented 2026-05-21 21:51:46 +02:00
Owner
Copy Link
Copy Source

There is no error handling if a locale does not exist.

There is no error handling if a locale does not exist.
jakob.scheid added 1 commit 2026-05-21 21:57:44 +02:00
Address the user formally in the German translations f08acad086
jakob.scheid added 1 commit 2026-05-21 22:00:03 +02:00
Speak English in a comment be19a3c29e
jakob.scheid reviewed 2026-05-21 22:02:02 +02:00
src/i18n.js Outdated
@@ -21,3 +21,3 @@
const SUPPORTED_LANGUAGES = [
'en'
'en', 'de', 'fr', 'es', 'it', 'pt', 'zh', 'ja', 'ar', 'hi'
jakob.scheid commented 2026-05-21 22:02:02 +02:00
Owner
Copy Link
Copy Source

Not all of these languages are supported.

Not all of these languages are supported.
jakob.scheid marked this conversation as resolved
jakob.scheid added 4 commits 2026-05-21 22:32:49 +02:00
Add list with languages written from right to left b30aea57ad
Remove unsupported languages from SUPPORTED_LANGUAGES 6f164a0256
Format SUPPORTED_LANGUAGES more readable 420f47dca4
Use translations in the translation files instead of hard-coded strings for the language names 258a4025bc
jakob.scheid reviewed 2026-05-21 22:42:24 +02:00
jakob.scheid added 1 commit 2026-05-21 23:29:13 +02:00
Add feature to close the language switching dropdown when the user clicks outside of it 006bb5136e
jakob.scheid reviewed 2026-05-21 23:31:51 +02:00
src/features/i18n/components/LanguageSwitchButton.vue
@@ -0,0 +111,4 @@
border-radius: 6px;
padding: 4px 10px;
cursor: pointer;
font-size: 0.9rem;
jakob.scheid commented 2026-05-21 23:31:51 +02:00
Owner
Copy Link
Copy Source

Why did you do that?

Why did you do that?
jakob.scheid marked this conversation as resolved
jakob.scheid added 1 commit 2026-05-21 23:33:26 +02:00
Remove CSS font-size property 3af6cb3c16
jakob.scheid added 2 commits 2026-05-22 14:19:17 +02:00
Update border color of language dropdown 666ecb4e98
Update border color of language button 3ca938d65b
jakob.scheid added 1 commit 2026-05-22 14:21:45 +02:00
Align right navbar links vertically centered 619d4065b3
jakob.scheid added 1 commit 2026-05-22 15:21:55 +02:00
Include flags in the language name translations instead of hard-coding it in the language switch button component abbfd0ad9d
jakob.scheid marked the pull request as work in progress 2026-05-22 15:53:51 +02:00
jakob.scheid added 1 commit 2026-05-22 17:18:34 +02:00
Remove flags from language labels 2bf433621a
jakob.scheid marked the pull request as ready for review 2026-05-22 17:18:45 +02:00
jakob.scheid approved these changes 2026-05-22 17:19:13 +02:00
jakob.scheid merged commit 9aecc195a9 into main 2026-05-22 17:19:25 +02:00
jakob.scheid deleted branch feature/add-languages 2026-05-22 17:19:25 +02:00
jakob.scheid moved this to Done in MVP Frontend on 2026-05-22 17:25:16 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
jakob.scheid
Labels
Clear labels
area/global
area
search-results
area
settings
area
startpage
prio
critical
prio
high
prio
low
prio
medium
type
bug
type
chore
type
docs
type
feature
type
refactor
type
testing
type/urgent
No Label area/global
prio
low
type
feature
Milestone
No items
No Milestone mvp-frontend
Projects
Clear projects
No project MVP Frontend
Assignees
Clear assignees
jakob.gregory (Jakob Gregory) jakob.scheid (Jakob Scheid) johannes.vos (Johannes D. Vos)
No Assignees johannes.vos
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Seekra/frontend#70
Delete Branch "feature/add-languages"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?