Seekra/frontend
3
2
Fork 0
generated from Seekra/repository-template
Code Issues 4 Pull Requests Actions Packages Projects 1 Releases Wiki Activity

Add NotFound.vue #48 #50

Merged
jakob.scheid merged 22 commits from feature/not-found-page into main 2026-05-14 16:21:30 +02:00
Conversation 8 Commits 22 Files Changed 3
+40 -1
johannes.vos commented 2026-05-14 12:38:54 +02:00
Member
Copy Link
Copy Source
No description provided.
johannes.vos added this to the mvp-frontend milestone 2026-05-14 12:38:54 +02:00
johannes.vos added the
prio
high
type
feature
area/global labels 2026-05-14 12:38:54 +02:00
johannes.vos self-assigned this 2026-05-14 12:38:54 +02:00
johannes.vos added this to the MVP Frontend project 2026-05-14 12:38:54 +02:00
johannes.vos added 15 commits 2026-05-14 12:38:54 +02:00
Add NotFound.vue 336a063d1e
Add template in NotFound.vue 8d93ba2638
Add Router 25958bf7bb
Fix Router bug 6f93d42b02
Change Text in NotFound.vue d2302afdc4
Remove unnecessary Form 237fcd33dc
Copy style from SearchView.vue ba6e8e652d
Make .slogan bigger 2956c54496
merge: resolve conflict, add NotFound route 9b04b00c11
chore: update package-lock.json 06f7037e11
Add script 78679fe03b
Remove unnecesary script fb5985dcb1
Add RouterLink to Searchview.vue 6aca8a6087
Rename class 'slogan' to 'error-message' 61e4f3d1f2
Add Link Style 08c3de5cb2
jakob.scheid moved this to In progress in MVP Frontend on 2026-05-14 13:08:40 +02:00
jakob.scheid moved this to Review in MVP Frontend on 2026-05-14 13:08:43 +02:00
jakob.scheid reviewed 2026-05-14 13:15:27 +02:00
src/router/index.js Outdated
@@ -39,0 +39,4 @@
},
{
path: '/:pathMatch(.*)*',
name: 'not-found',
jakob.scheid commented 2026-05-14 13:15:27 +02:00
Owner
Copy Link
Copy Source

Use camel case (notFound).

Use camel case (*notFound*).
jakob.scheid marked this conversation as resolved
jakob.scheid reviewed 2026-05-14 13:17:16 +02:00
src/router/index.js Outdated
@@ -39,3 +45,3 @@
];
const router = createRouter({
const router = createRouter({
jakob.scheid commented 2026-05-14 13:17:16 +02:00
Owner
Copy Link
Copy Source

Omit the space at the end of the line.

Omit the space at the end of the line.
jakob.scheid marked this conversation as resolved
jakob.scheid reviewed 2026-05-14 13:18:20 +02:00
src/views/NotFound.vue Outdated
@@ -0,0 +11,4 @@
</template>
<style scoped>
.global-header {
jakob.scheid commented 2026-05-14 13:18:20 +02:00
Owner
Copy Link
Copy Source

Copying styles is a very bad idea. Nothing should be redundant.

Copying styles is a very bad idea. Nothing should be redundant.
jakob.scheid marked this conversation as resolved
jakob.scheid reviewed 2026-05-14 13:19:17 +02:00
src/views/NotFound.vue Outdated
@@ -0,0 +3,4 @@
<header class="global-header">
<h1>Seekra</h1>
<span class="error-message">
ERROR 404: Page Not Found
jakob.scheid commented 2026-05-14 13:19:17 +02:00
Owner
Copy Link
Copy Source

Do not write ERROR uppercase.

Do not write *ERROR* uppercase.
jakob.scheid marked this conversation as resolved
jakob.scheid reviewed 2026-05-14 13:20:28 +02:00
src/views/NotFound.vue Outdated
@@ -0,0 +1,51 @@
<template>
<div class="search-content">
jakob.scheid commented 2026-05-14 13:20:28 +02:00
Owner
Copy Link
Copy Source

Do not use a container .search-content in a not found page.

Do not use a container *.search-content* in a not found page.
jakob.scheid marked this conversation as resolved
jakob.scheid reviewed 2026-05-14 13:21:22 +02:00
src/views/NotFound.vue Outdated
@@ -0,0 +2,4 @@
<div class="search-content">
<header class="global-header">
<h1>Seekra</h1>
<span class="error-message">
jakob.scheid commented 2026-05-14 13:21:22 +02:00
Owner
Copy Link
Copy Source

No HTTP status code. That is confusing for people who are not familiar with technology.

No HTTP status code. That is confusing for people who are not familiar with technology.
jakob.scheid marked this conversation as resolved
jakob.scheid reviewed 2026-05-14 13:22:08 +02:00
src/views/NotFound.vue Outdated
@@ -0,0 +1,51 @@
<template>
<div class="search-content">
<header class="global-header">
jakob.scheid commented 2026-05-14 13:22:08 +02:00
Owner
Copy Link
Copy Source

The not found page should be minimal, so omit the header. The navigation bar already contains Seekra.

The not found page should be minimal, so omit the header. The navigation bar already contains *Seekra*.
jakob.scheid marked this conversation as resolved
jakob.scheid changed title from Add NotFound.vue to Add NotFound.vue #48 2026-05-14 13:26:25 +02:00
johannes.vos added 7 commits 2026-05-14 16:06:52 +02:00
fix: use camelCase for not-found route name f152d39db8
Remove space a45e208f9b
Remove <div class=search-content> 7098414db1
Make the error code more human-readable 7b601416ad
Remove header 22c3aafcc5
Remove unnecessary Style 6175e3b0be
Add style for the content cf7525b32a
jakob.scheid approved these changes 2026-05-14 16:21:16 +02:00
jakob.scheid left a comment
Owner
Copy Link
Copy Source

Good

Good
jakob.scheid merged commit fc23a6d185 into main 2026-05-14 16:21:30 +02:00
jakob.scheid deleted branch feature/not-found-page 2026-05-14 16:21:30 +02:00
jakob.scheid moved this to Done in MVP Frontend on 2026-05-14 16:21:36 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
jakob.scheid
Labels
Clear labels
area/global
area
search-results
area
settings
area
startpage
prio
critical
prio
high
prio
low
prio
medium
type
bug
type
chore
type
docs
type
feature
type
refactor
type
testing
type/urgent
No Label area/global
prio
high
type
feature
Milestone
No items
No Milestone mvp-frontend
Projects
Clear projects
No project MVP Frontend
Assignees
Clear assignees
jakob.gregory (Jakob Gregory) jakob.scheid (Jakob Scheid) johannes.vos (Johannes D. Vos)
No Assignees johannes.vos
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Seekra/frontend#50
Delete Branch "feature/not-found-page"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?