Seekra/frontend
3
3
Fork 0
generated from Seekra/repository-template
Code Issues 10 Pull Requests 1 Actions Packages Projects 1 Releases 1 Wiki Activity

Fix(sidebar): hide sidebar instead of removing it when it is not expanded #174

Merged
jakob.scheid merged 1 commits from fix/settings-view into main 2026-08-06 12:47:41 +02:00
Conversation 0 Commits 1 Files Changed 1
+1 -1
jakob.scheid commented 2026-08-05 19:45:25 +02:00
Owner
Copy Link
Copy Source

This pull requests hides the sidebar instead of removing it from DOM when it is not expanded. Removing it could cause behavior, such as tests which test its content failing. Tests now are no longer affected by the sidebar visibility.

Related issues

Closes #166

This pull requests hides the sidebar instead of removing it from DOM when it is not expanded. Removing it could cause behavior, such as tests which test its content failing. Tests now are no longer affected by the sidebar visibility. # Related issues Closes #166
jakob.scheid added this to the 0.1.0 milestone 2026-08-05 19:45:25 +02:00
jakob.scheid added the
Priority
High
2
Kind/BugArea/Sidebar labels 2026-08-05 19:45:25 +02:00
jakob.scheid added this to the Project Board project 2026-08-05 19:45:25 +02:00
jakob.scheid moved this to Review in Project Board on 2026-08-05 19:45:29 +02:00
jakob.scheid added 1 commit 2026-08-05 20:46:37 +02:00
fix(sidebar): hide sidebar instead of removing it 32555d9acb 
Previously, the sidebar was fully removed from DOM. This could cause
unwanted behavior, such as tests which test its content failing. Now, it
is just hidden. This does not affect tests any more.
jakob.scheid force-pushed fix/settings-view from 1bb70046c3 to 32555d9acb 2026-08-05 20:46:37 +02:00 Compare
jakob.gregory approved these changes 2026-08-06 12:47:05 +02:00
jakob.scheid merged commit b0642cc826 into main 2026-08-06 12:47:41 +02:00
jakob.scheid deleted branch fix/settings-view 2026-08-06 12:47:41 +02:00
jakob.scheid moved this to Done in Project Board on 2026-08-06 12:47:49 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
jakob.gregory
Labels
Clear labels
Area/Global
A global issue or pull request
 Area/Legal
Area/Search Results
An issue or pull requests related to the search results feature
 Area/Settings
The issue or pull request is related to the settings
 Area/Sidebar
The issue or pull request is related to the sidebar
 Area/Start page
Related to the start page
 Compat/Breaking
Breaking change that will not be backward compatible
 Kind/Bug
Something is not working
 Kind/Chore
Chore and maintainerance
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Refactor
Refactoring code
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
 Kind/Urgent
The issue or pull request is urgent
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Will Not Fix
3
This issue will not be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No labels Area/Sidebar Kind/Bug
Priority
High
2
Milestone
No items
No Milestone 0.1.0
Projects
Clear projects
No projects
Project Board
Done
Assignees
Clear assignees
jakob.gregory (Jakob Gregory) jakob.scheid (Jakob Scheid) johannes.vos (Johannes Vos)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Seekra/frontend#174