test(settings): add test cases for empty setting value return value

Added a store to cache the settings configuration. The getSetting
function from useSettings is now synchronous and uses this cache.
The settings cache is set when loading the settings initially
(asnychronously).

src/App.vue

@@ -26,7 +26,7 @@ import { useRoute } from 'vue-router';
 const route = useRoute();
 
 const { getColorScheme, updateColorScheme } = useColorScheme();
-const colorScheme = ref(null);
+const colorScheme = ref(getColorScheme());
 provide('colorScheme', colorScheme);
 watch(colorScheme, (newValue) => {
     updateColorScheme(newValue);
@@ -46,7 +46,6 @@ watch(colorScheme, (newValue) => {
         document.body.classList.remove('color-scheme-auto');
     }
 });
-colorScheme.value = getColorScheme();
 
 watchEffect(() => updatePageTitle(route));
 </script>

src/features/footer/components/Footer.vue

@@ -54,7 +54,6 @@ const copyrightPeriod =
 .footer-segment {
     display: flex;
     justify-content: center;
-    align-items: center;
     gap: 32px;
     padding: var(--padding-y);
     background-color: var(--light-bg);

src/features/settings/components/Switch.vue

@@ -16,7 +16,7 @@ limitations under the License.
 
 <script setup>
 import { useSettingsStore } from '../stores/settingsStore';
-import { ref, useId, watch } from 'vue';
+import { useId } from 'vue';
 import { useI18n } from 'vue-i18n';
 
 const { t } = useI18n();
@@ -35,16 +35,8 @@ const switchId = useId();
 
 const store = useSettingsStore();
 
-const enabled = ref(null);
-watch(store, (newStore) => {
-    enabled.value = newStore.get(props.path);
-});
-// set value after registering watcher to avoid immediate value change
-enabled.value = store.get(props.path) ?? props.setting.default;
-
 const toggle = function toggle () {
-    enabled.value = !enabled.value;
+    store.set(props.path, !store.get(props.path));
-    store.set(props.path, enabled.value);
 };
 </script>
 
@@ -55,7 +47,7 @@ const toggle = function toggle () {
         </label>
         <div
             class="switch-wrapper"
-            :class="{ enabled }"
+            :class="{ enabled: store.get(props.path) }"
             :title="t('settings.switch.title')"
             :aria-label="t('settings.switch.ariaLabel')"
             :aria-labelledby="labelId"

src/features/settings/components/__tests__/Switch.test.js

@@ -20,23 +20,17 @@ import { useSettingsStore } from '../../stores/settingsStore.js';
 import { expect, describe, test } from 'vitest';
 import { nextTick } from 'vue';
 
-const getWrapper = function getWrapper ({
+const getWrapper = function getWrapper ({ i18n = 'switch1', translations = {} } = {}) {
-    i18n = 'switch1',
-    defaultValue = undefined,
-    translations = {},
-    piniaOptions = {}
-} = {}) {
     return mountComponent(Switch, {
         attrs: {
             setting: {
                 type: 'bool',
                 name: 'switch',
-                i18n,
+                i18n
-                default: defaultValue
             },
             path: 'switch'
         }
-    }, translations, [], piniaOptions);
+    }, translations);
 };
 
 describe('Switch', () => {
@@ -59,42 +53,6 @@ describe('Switch', () => {
         expect(switchElementClasses2).not.toContain('enabled');
     });
 
-    test('shows default value', () => {
-        const wrapper = getWrapper({
-            defaultValue: true
-        });
-
-        const switchElement = wrapper.find('.switch-wrapper');
-        expect(switchElement.classes('enabled')).toBeTruthy();
-    });
-
-    test('shows stored value instead of default value', () => {
-        const wrapper = getWrapper({
-            defaultValue: true,
-            piniaOptions: {
-                setupStores: () => {
-                    const store = useSettingsStore();
-                    store.set('switch', false);
-                }
-            }
-        });
-
-        const switchElement = wrapper.find('.switch-wrapper');
-        expect(switchElement.classes('enabled')).toBeFalsy();
-    });
-
-    test('reacts on store change', async () => {
-        const wrapper = getWrapper();
-        const store = useSettingsStore();
-
-        const switchElement = wrapper.find('.switch-wrapper');
-        expect(switchElement.classes('enabled')).toBeFalsy();
-        
-        store.set('switch', true);
-        await nextTick();
-        expect(switchElement.classes('enabled')).toBeTruthy();
-    });
-
     test('toggles value in store', async () => {
         const wrapper = getWrapper();
         

src/features/settings/composables/__tests__/useSettings.test.js

@@ -26,7 +26,7 @@ const settingPath = ['test', 'number'];
 
 describe('useSettings', () => {
     describe('getSetting', () => {
-        test('returns stored value', () => {
+        test('returns stored value', async () => {
             const { getSetting } = useSettings();
             const settings = useSettingsStore();
 
@@ -35,24 +35,24 @@ describe('useSettings', () => {
 
             settings.set(key, value);
 
-            expect(getSetting(key)).toBe(value);
+            expect(await getSetting(key)).toBe(value);
         });
 
-        test('returns default value', () => {
+        test('returns default value', async () => {
             const { getSetting } = useSettings();
-            expect(getSetting(settingPath)).toBe(settingDefaultValue);
+            expect(await getSetting(settingPath)).toBe(settingDefaultValue);
         });
 
-        test('returns stored value instead of default value', () => {
+        test('returns stored value instead of default value', async () => {
             const { getSetting } = useSettings();
             const settings = useSettingsStore();
 
             const value = 43;
 
-            expect(getSetting(settingPath)).toBe(settingDefaultValue);
+            expect(await getSetting(settingPath)).toBe(settingDefaultValue);
 
             settings.set(settingPath, value);
-            expect(getSetting(settingPath)).toBe(value);
+            expect(await getSetting(settingPath)).toBe(value);
         });
 
         test('returns undefined if there is no value', () => {

src/features/settings/composables/useSettings.js

@@ -40,15 +40,5 @@ export const useSettings = function useSettings () {
         );
     };
 
-    /**
+    return { getSetting };
-     * Sets the value of a specific setting.
-     * @param {string[]} key - The setting key.
-     * @param value - The new value for the setting.
-     */
-    const setSetting = function setSetting (key, value) {
-        const settingsStore = useSettingsStore();
-        settingsStore.set(key.join('.'), value);
-    };
-
-    return { getSetting, setSetting };
 };

src/features/sidebar/components/Sidebar.vue

@@ -36,7 +36,7 @@ const toggleSidebar = function toggleSidebar () {
         <div class="sidebar-controls">
             <SidebarExpandButton @click="toggleSidebar" class="sidebar-expand-button" />
         </div>
-        <div class="sidebar-content" v-show="props.expanded">
+        <div class="sidebar-content" v-if="props.expanded">
             <slot />
         </div>
     </nav>
@@ -61,10 +61,6 @@ const toggleSidebar = function toggleSidebar () {
 }
 
 @media (max-width: 48rem) {
-    .sidebar {
-        border: none;
-    }
-
     .sidebar:not(.expanded) .sidebar-expand-button {
         display: none;
     }