From ecf9074522722a19826025f149390b0866b5f671 Mon Sep 17 00:00:00 2001
From: Jakob Scheid <jakob.scheid@icloud.com>
Date: Thu, 4 Jun 2026 14:53:47 +0200
Subject: [PATCH] test(settings): add unit test for the settings validator
 validateEntry function for test cases that should not throw an error

---
 .../utils/__tests__/settingsValidator.test.js | 45 ++++++++++++++++++-
 .../settings/utils/settingsValidator.js       |  2 +-
 2 files changed, 45 insertions(+), 2 deletions(-)

diff --git a/src/features/settings/utils/__tests__/settingsValidator.test.js b/src/features/settings/utils/__tests__/settingsValidator.test.js
index bb251af..3444b3a 100644
--- a/src/features/settings/utils/__tests__/settingsValidator.test.js
+++ b/src/features/settings/utils/__tests__/settingsValidator.test.js
@@ -15,14 +15,57 @@ limitations under the License.
 */
 
 import { describe, test, expect } from 'vitest';
-import { validateSelectionOptions, assertType, assertString } from '../settingsValidator';
+import { validateEntry, validateSelectionOptions, assertType, assertString } from '../settingsValidator';
 
 describe('validateSettingsConfig', () => {
 
 });
 
 describe('validateEntry', () => {
+    test.for([
+        [{ name: 'enableFeature42', type: 'bool', i18n: 'feature.42.enable' }],
+        [{ name: 'enableFeature42', type: 'bool', i18n: 'feature.42.enable', default: true }],
+        [{ name: 'enableFeature42', type: 'bool', i18n: 'feature.42.enable', default: false }],
+    
+        [{ name: 'aNumber', type: 'number', i18n: 'aNumber.label' }],
+        [{ name: 'aNumber', type: 'number', i18n: 'aNumber.label', default: 42 }],
+        [{ name: 'aNumber', type: 'number', i18n: 'aNumber.label', default: 0 }],
+        [{ name: 'aNumber', type: 'number', i18n: 'aNumber.label', default: -42.7 }],
+    
+        [{ name: 'aString', type: 'string', i18n: 'aString.label' }],
+        [{ name: 'aString', type: 'string', i18n: 'aString.label', default: '' }],
+        [{ name: 'aString', type: 'string', i18n: 'aString.label', default: 'Seekra is great!' }],
 
+        [{ name: 'selectSomething', type: 'selection', i18n: 'selectSomething.title', options: [
+            { name: 'yes', i18n: 'selectSomething.options.yes' },
+            { name: 'no', i18n: 'selectSomething.options.no' },
+            { name: 'maybe', i18n: 'selectSomething.options.maybe' }
+        ] }],
+
+        [{ name: 'selectSomething', type: 'selection', i18n: 'selectSomething.title', default: 'no', options: [
+            { name: 'yes', i18n: 'selectSomething.options.yes' },
+            { name: 'no', i18n: 'selectSomething.options.no' },
+            { name: 'maybe', i18n: 'selectSomething.options.maybe' }
+        ] }],
+
+        [{ name: 'aSection', type: 'section', i18n: 'sections.aSection.title', content: [] }],
+        [{ name: 'aSection', type: 'section', i18n: 'sections.aSection.title', content: [
+            { name: 'enableFeature42', type: 'bool', i18n: 'feature.42.enable', default: true }
+        ] }],
+        [{ name: 'aSection', type: 'section', i18n: 'sections.aSection.title', content: [
+            { name: 'enableFeature42', type: 'bool', i18n: 'feature.42.enable', default: true },
+            { name: 'enableFeature43', type: 'bool', i18n: 'feature.43.enable', default: true }
+        ] }],
+        [{ name: 'aSection', type: 'section', i18n: 'sections.aSection.title', content: [
+            { name: 'enableFeature42', type: 'bool', i18n: 'feature.42.enable', default: true },
+            { name: 'enableFeature43', type: 'bool', i18n: 'feature.43.enable', default: true },
+            { name: 'aSecondSection', type: 'section', i18n: 'sections.aSecondSection.title', content: [
+                { name: 'enableFeature44', type: 'bool', i18n: 'feature.44.enable', default: true },
+            ] }
+        ] }]
+    ])('throws no error for the entry %s', ([ entry ]) => {
+        expect(() => validateEntry(entry)).not.throws(Error);
+    });
 });
 
 describe('validateSelectionOptions', () => {
diff --git a/src/features/settings/utils/settingsValidator.js b/src/features/settings/utils/settingsValidator.js
index a663a3a..fe693d6 100644
--- a/src/features/settings/utils/settingsValidator.js
+++ b/src/features/settings/utils/settingsValidator.js
@@ -40,7 +40,7 @@ export const validateSelectionOptions = function validateSelectionOptions (optio
     });
 }
 
-function validateEntry(entry, path) {
+export const validateEntry = function validateEntry (entry, path) {
     assertType(entry.type, `${path}.type`);
 
     if (entry.type === 'section') {