Seekra/frontend
3
3
Fork 0
generated from Seekra/repository-template
Code Issues 9 Pull Requests Actions Packages Projects 1 Releases 1 Wiki Activity

fix(settings): omit leading/trailing and consecuting dots in noralizePagePath

Browse Source
This commit is contained in:
jakob.scheid
2026-07-28 20:10:20 +02:00
parent c2402f9360
commit d3f3ef37ed
2 changed files with 30 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/features/settings/composables/__tests__/useSettingsPage.test.js
+26 -3
View File
@@ -26,11 +26,34 @@ vi.mock('vue-router', () => ({
describe('useSettingsPage', () => { describe('useSettingsPage', () => {
describe('goToSettingsPage', () => { describe('goToSettingsPage', () => {
test('goes to correct route', async () => { test.for([
{ settingsPath: 'a.b.c', expectedRoute: '/settings/a/b/c' },
{ settingsPath: 'a', expectedRoute: '/settings/a' },
{ settingsPath: 'a.b', expectedRoute: '/settings/a/b' },
{ settingsPath: 'a..b', expectedRoute: '/settings/a/b' },
{ settingsPath: '.a.b', expectedRoute: '/settings/a/b' },
{ settingsPath: '..a.b', expectedRoute: '/settings/a/b' },
{ settingsPath: '.a.b.', expectedRoute: '/settings/a/b' },
{ settingsPath: '..a.b..', expectedRoute: '/settings/a/b' },
{ settingsPath: 'a.b.', expectedRoute: '/settings/a/b' },
{ settingsPath: 'a.b..', expectedRoute: '/settings/a/b' },
{ settingsPath: '.a.b..', expectedRoute: '/settings/a/b' },
{ settingsPath: '..a.b.', expectedRoute: '/settings/a/b' },
{ settingsPath: '.a..b', expectedRoute: '/settings/a/b' },
{ settingsPath: '..a..b', expectedRoute: '/settings/a/b' },
{ settingsPath: '.a..b.', expectedRoute: '/settings/a/b' },
{ settingsPath: '..a..b..', expectedRoute: '/settings/a/b' },
{ settingsPath: 'a..b.', expectedRoute: '/settings/a/b' },
{ settingsPath: 'a..b..', expectedRoute: '/settings/a/b' },
{ settingsPath: '.a..b..', expectedRoute: '/settings/a/b' },
{ settingsPath: '..a..b.', expectedRoute: '/settings/a/b' },
{ settingsPath: '..a.....b.c..d....', expectedRoute: '/settings/a/b/c/d' }
])('goes to correct route', async ({ settingsPath, expectedRoute }) => {
const { goToSettingsPage } = useSettingsPage(); const { goToSettingsPage } = useSettingsPage();
await goToSettingsPage('a.b.c'); await goToSettingsPage(settingsPath);
expect(pushRoute).toHaveBeenCalledWith('/settings/a/b/c'); expect(pushRoute).toHaveBeenCalledWith(expectedRoute);
pushRoute.mockClear();
}); });
}); });
}); });
src/features/settings/composables/useSettingsPage.js
+4 -1
View File
@@ -17,7 +17,10 @@ limitations under the License.
import { useRouter } from 'vue-router'; import { useRouter } from 'vue-router';
const normalizePagePath = function normalizePagePath (path) { const normalizePagePath = function normalizePagePath (path) {
return path.replaceAll('.', '/'); return path
.replace(/\.+/g, '.')
.replace(/^\.+|\.+$/g, '')
.replaceAll('.', '/');
}; };
export const useSettingsPage = function useSettingsPage () { export const useSettingsPage = function useSettingsPage () {