From c2402f9360c8cf6c019dc8cde944cb61ff7c2b71 Mon Sep 17 00:00:00 2001 From: Jakob Scheid Date: Sun, 26 Jul 2026 18:45:04 +0200 Subject: [PATCH] fix(settings): return router.push promise The settings page composable function to go to a settings page now returns the promise router.push returns. --- .../settings/composables/__tests__/useSettingsPage.test.js | 4 ++-- src/features/settings/composables/useSettingsPage.js | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/features/settings/composables/__tests__/useSettingsPage.test.js b/src/features/settings/composables/__tests__/useSettingsPage.test.js index 1c5c9d0..e790d9a 100644 --- a/src/features/settings/composables/__tests__/useSettingsPage.test.js +++ b/src/features/settings/composables/__tests__/useSettingsPage.test.js @@ -26,10 +26,10 @@ vi.mock('vue-router', () => ({ describe('useSettingsPage', () => { describe('goToSettingsPage', () => { - test('goes to correct route', () => { + test('goes to correct route', async () => { const { goToSettingsPage } = useSettingsPage(); - goToSettingsPage('a.b.c'); + await goToSettingsPage('a.b.c'); expect(pushRoute).toHaveBeenCalledWith('/settings/a/b/c'); }); }); diff --git a/src/features/settings/composables/useSettingsPage.js b/src/features/settings/composables/useSettingsPage.js index 0dc43a9..af0da5a 100644 --- a/src/features/settings/composables/useSettingsPage.js +++ b/src/features/settings/composables/useSettingsPage.js @@ -24,7 +24,7 @@ export const useSettingsPage = function useSettingsPage () { const router = useRouter(); const goToSettingsPage = function goToSettingsPage (pagePath) { - router.push(`/settings/${normalizePagePath(pagePath)}`); + return router.push(`/settings/${normalizePagePath(pagePath)}`); }; return { goToSettingsPage };