From ad6f59a85c2c6c8230044bdeabd2c68fec868e01 Mon Sep 17 00:00:00 2001 From: Jakob Scheid Date: Thu, 6 Aug 2026 19:49:12 +0200 Subject: [PATCH] fix(settings): fix useSettings getSetting store path --- .../composables/__tests__/useSettings.test.js | 16 ++++++---------- src/features/settings/composables/useSettings.js | 2 +- 2 files changed, 7 insertions(+), 11 deletions(-) diff --git a/src/features/settings/composables/__tests__/useSettings.test.js b/src/features/settings/composables/__tests__/useSettings.test.js index ddcdba8..aec200d 100644 --- a/src/features/settings/composables/__tests__/useSettings.test.js +++ b/src/features/settings/composables/__tests__/useSettings.test.js @@ -14,7 +14,6 @@ See the License for the specific language governing permissions and limitations under the License. */ -import { useSettingsStore } from '../../stores/settingsStore'; import { useSettings } from '../useSettings'; import { createTestingPinia } from '@pinia/testing'; import { setActivePinia } from 'pinia'; @@ -50,31 +49,28 @@ vi.mock('../../settings.json', () => ({ describe('useSettings', () => { describe('getSetting', () => { test('returns stored value', () => { - const { getSetting } = useSettings(); - const settings = useSettingsStore(); + const { getSetting, setSetting } = useSettings(); - const key = 'setting'; + const key = ['setting']; const value = 42; - settings.set(key, value); - + setSetting(key, value); expect(getSetting(key)).toBe(value); }); test('returns default value', () => { - const { getSetting } = useSettings(); + const { getSetting, setSetting } = useSettings(); expect(getSetting(settingPath)).toBe(settingDefaultValue); }); test('returns stored value instead of default value', () => { - const { getSetting } = useSettings(); - const settings = useSettingsStore(); + const { getSetting, setSetting } = useSettings(); const value = 43; expect(getSetting(settingPath)).toBe(settingDefaultValue); - settings.set(settingPath, value); + setSetting(settingPath, value); expect(getSetting(settingPath)).toBe(value); }); diff --git a/src/features/settings/composables/useSettings.js b/src/features/settings/composables/useSettings.js index e87e839..8c469a6 100644 --- a/src/features/settings/composables/useSettings.js +++ b/src/features/settings/composables/useSettings.js @@ -31,7 +31,7 @@ export const useSettings = function useSettings () { const settingsStore = useSettingsStore(); return ( - settingsStore.get(key) ?? + settingsStore.get(key.join('.')) ?? getSettingRecursively( key, settings.contents ?? [] )?.default