From 122663e2e36380b209efcfadb0d2a8cf1dc9980c Mon Sep 17 00:00:00 2001 From: Jakob Scheid Date: Thu, 4 Jun 2026 15:15:37 +0200 Subject: [PATCH] fix(settings): check the name and i18n before the checks for a section in validateEntry in the settings validator --- src/features/settings/utils/settingsValidator.js | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/features/settings/utils/settingsValidator.js b/src/features/settings/utils/settingsValidator.js index 8cb9652..b792c61 100644 --- a/src/features/settings/utils/settingsValidator.js +++ b/src/features/settings/utils/settingsValidator.js @@ -42,9 +42,11 @@ export const validateSelectionOptions = function validateSelectionOptions (optio export const validateEntry = function validateEntry (entry, path) { assertType(entry.type, `${path}.type`); + + assertString(entry.name, `${path}.name`); + assertString(entry.i18n, `${path}.i18n`); if (entry.type === 'section') { - assertString(entry.name, `${path}.name`); if (!Array.isArray(entry.content)) { throw new Error(`[settings] "${path}.content" must be an array`); } @@ -54,9 +56,6 @@ export const validateEntry = function validateEntry (entry, path) { return; } - assertString(entry.name, `${path}.name`); - assertString(entry.i18n, `${path}.i18n`); - if (entry.default !== undefined) { if (entry.type === 'bool' && typeof entry.default !== 'boolean') { throw new Error(`[settings] "${path}.default" must be a boolean`);